The present work critically reviewed hydrogen diffusion and permeation in metals. The roles of temperature, stress and traps in hydrogen diffusion and permeation are discussed. Especially, we focused on the controversial problems such as hydrogen diffusion along dislocations and grain boundaries, and the influence of the surface state on measurement of hydrogen diffusivities.